Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more macos versions to test #859

Merged
merged 2 commits into from
Jan 30, 2025
Merged

add more macos versions to test #859

merged 2 commits into from
Jan 30, 2025

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Jan 30, 2025

let's test more macOS

the following error message only exist on macOS 13 and 14, but not on macOS 15 builds

/Users/runner/work/ada/ada/include/ada/parser-inl.h:117:16: error: 'protocol_component' is a private member of 'ada::url_pattern<ada::url_pattern_regex::std_regex_provider>'
  url_pattern_.protocol_component = std::move(*protocol_component);
               ^
/Users/runner/work/ada/ada/include/ada/implementation-inl.h:21:18: note: in instantiation of function template specialization 'ada::parser::parse_url_pattern_impl<ada::url_pattern_regex::std_regex_provider>' requested here
  return parser::parse_url_pattern_impl<regex_provider>(std::move(input),
                 ^
/Users/runner/work/ada/ada/tests/wpt_urlpattern_tests.cpp:29:12: note: in instantiation of function template specialization 'ada::parse_url_pattern<ada::url_pattern_regex::std_regex_provider>' requested here
      ada::parse_url_pattern<ada::url_pattern_regex::std_regex_provider>(init);
           ^
/Users/runner/work/ada/ada/include/ada/url_pattern.h:293:41: note: declared private here
  url_pattern_component<regex_provider> protocol_component{};
                                        ^
In file included from /Users/runner/work/ada/ada/tests/wpt_urlpattern_tests.cpp:8:
In file included from /Users/runner/work/ada/ada/include/ada.h:17:
/Users/runner/work/ada/ada/include/ada/parser-inl.h:131:16: error: 'username_component' is a private member of 'ada::url_pattern<ada::url_pattern_regex::std_regex_provider>'
  url_pattern_.username_component = std::move(*username_component);
               ^
/Users/runner/work/ada/ada/include/ada/url_pattern.h:294:41: note: declared private here
  url_pattern_component<regex_provider> username_component{};
                                        ^
In file included from /Users/runner/work/ada/ada/tests/wpt_urlpattern_tests.cpp:8:
In file included from /Users/runner/work/ada/ada/include/ada.h:17:
/Users/runner/work/ada/ada/include/ada/parser-inl.h:145:16: error: 'password_component' is a private member of 'ada::url_pattern<ada::url_pattern_regex::std_regex_provider>'
  url_pattern_.password_component = std::move(*password_component);
               ^
/Users/runner/work/ada/ada/include/ada/url_pattern.h:295:41: note: declared private here
  url_pattern_component<regex_provider> password_component{};
                                        ^
In file included from /Users/runner/work/ada/ada/tests/wpt_urlpattern_tests.cpp:8:
In file included from /Users/runner/work/ada/ada/include/ada.h:17:
/Users/runner/work/ada/ada/include/ada/parser-inl.h:167:18: error: 'hostname_component' is a private member of 'ada::url_pattern<ada::url_pattern_regex::std_regex_provider>'
    url_pattern_.hostname_component = std::move(*hostname_component);
                 ^
/Users/runner/work/ada/ada/include/ada/url_pattern.h:296:41: note: declared private here
  url_pattern_component<regex_provider> hostname_component{};
                                        ^
In file included from /Users/runner/work/ada/ada/tests/wpt_urlpattern_tests.cpp:8:
In file included from /Users/runner/work/ada/ada/include/ada.h:17:
/Users/runner/work/ada/ada/include/ada/parser-inl.h:181:18: error: 'hostname_component' is a private member of 'ada::url_pattern<ada::url_pattern_regex::std_regex_provider>'
    url_pattern_.hostname_component = std::move(*hostname_component);
                 ^
/Users/runner/work/ada/ada/include/ada/url_pattern.h:296:41: note: declared private here
  url_pattern_component<regex_provider> hostname_component{};
                                        ^
In file included from /Users/runner/work/ada/ada/tests/wpt_urlpattern_tests.cpp:8:
In file included from /Users/runner/work/ada/ada/include/ada.h:17:
/Users/runner/work/ada/ada/include/ada/parser-inl.h:194:16: error: 'port_component' is a private member of 'ada::url_pattern<ada::url_pattern_regex::std_regex_provider>'
  url_pattern_.port_component = std::move(*port_component);
               ^
/Users/runner/work/ada/ada/include/ada/url_pattern.h:297:41: note: declared private here
  url_pattern_component<regex_provider> port_component{};
                                        ^
In file included from /Users/runner/work/ada/ada/tests/wpt_urlpattern_tests.cpp:8:
In file included from /Users/runner/work/ada/ada/include/ada.h:17:
/Users/runner/work/ada/ada/include/ada/parser-inl.h:207:40: error: 'protocol_component' is a private member of 'ada::url_pattern<ada::url_pattern_regex::std_regex_provider>'
          regex_provider>(url_pattern_.protocol_component)) {
                                       ^
/Users/runner/work/ada/ada/include/ada/url_pattern.h:293:41: note: declared private here
  url_pattern_component<regex_provider> protocol_component{};
                                        ^
In file included from /Users/runner/work/ada/ada/tests/wpt_urlpattern_tests.cpp:8:
In file included from /Users/runner/work/ada/ada/include/ada.h:17:
/Users/runner/work/ada/ada/include/ada/parser-inl.h:226:18: error: 'pathname_component' is a private member of 'ada::url_pattern<ada::url_pattern_regex::std_regex_provider>'
    url_pattern_.pathname_component = std::move(*pathname_component);
                 ^
/Users/runner/work/ada/ada/include/ada/url_pattern.h:298:41: note: declared private here
  url_pattern_component<regex_provider> pathname_component{};
                                        ^
In file included from /Users/runner/work/ada/ada/tests/wpt_urlpattern_tests.cpp:8:
In file included from /Users/runner/work/ada/ada/include/ada.h:17:
/Users/runner/work/ada/ada/include/ada/parser-inl.h:239:18: error: 'pathname_component' is a private member of 'ada::url_pattern<ada::url_pattern_regex::std_regex_provider>'
    url_pattern_.pathname_component = std::move(*pathname_component);
                 ^
/Users/runner/work/ada/ada/include/ada/url_pattern.h:298:41: note: declared private here
  url_pattern_component<regex_provider> pathname_component{};
                                        ^
In file included from /Users/runner/work/ada/ada/tests/wpt_urlpattern_tests.cpp:8:
In file included from /Users/runner/work/ada/ada/include/ada.h:17:
/Users/runner/work/ada/ada/include/ada/parser-inl.h:252:16: error: 'search_component' is a private member of 'ada::url_pattern<ada::url_pattern_regex::std_regex_provider>'
  url_pattern_.search_component = std::move(*search_component);
               ^
/Users/runner/work/ada/ada/include/ada/url_pattern.h:299:41: note: declared private here
  url_pattern_component<regex_provider> search_component{};
                                        ^
In file included from /Users/runner/work/ada/ada/tests/wpt_urlpattern_tests.cpp:8:
In file included from /Users/runner/work/ada/ada/include/ada.h:17:
/Users/runner/work/ada/ada/include/ada/parser-inl.h:264:16: error: 'hash_component' is a private member of 'ada::url_pattern<ada::url_pattern_regex::std_regex_provider>'
  url_pattern_.hash_component = std::move(*hash_component);
               ^
/Users/runner/work/ada/ada/include/ada/url_pattern.h:300:41: note: declared private here
  url_pattern_component<regex_provider> hash_component{};
                                        ^
11 errors generated.

@anonrig anonrig requested a review from lemire January 30, 2025 20:24
Copy link
Member

@lemire lemire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not seem useful to me, but I do not mind.

@anonrig
Copy link
Member Author

anonrig commented Jan 30, 2025

It does not seem useful to me, but I do not mind.

macOS 13 and 14 builds are failing...

@lemire
Copy link
Member

lemire commented Jan 30, 2025

@anonrig I think that's an Apple/LLVM bug. It is very similar to the following issue...

llvm/llvm-project#77309

@anonrig
Copy link
Member Author

anonrig commented Jan 30, 2025

@lemire after talking with couple of folks, I can't seem to find any solution other than a revert.

@lemire
Copy link
Member

lemire commented Jan 30, 2025

@anonrig

after talking with couple of folks, I can't seem to find any solution other than a revert.

You may also want to document the choice you made... e.g., indicate that it is due to a bug in Apple/LLVM prior to 16.

@anonrig
Copy link
Member Author

anonrig commented Jan 30, 2025

You may also want to document the choice you made... e.g., indicate that it is due to a bug in Apple/LLVM prior to 16.

Good idea

@anonrig anonrig merged commit c1df595 into main Jan 30, 2025
43 checks passed
@anonrig anonrig deleted the add-more-macos branch January 30, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants